adding wrapper dsl query docs #9939
Conversation
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
AntonEliatra
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
added
3 - Tech review
|
@sgup432 Could you review this PR? Thanks! |
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
_query-dsl/specialized/wrapper.md
Outdated
| { | ||
| "query": { | ||
| "wrapper": { | ||
| "query": "eyAibWF0Y2giOiB7InRpdGxlIjogImhlYWRwaG9uZXMifSB9" |
There was a problem hiding this comment.
Curious as to where we decode this eventually? Also do we also need to mention here if any explicit plugin needs to be enabled to use this or basically any pre-requisite? @AntonEliatra
There was a problem hiding this comment.
@sgup432 this comes with standard opensearch, no special plugins needed. I dont think we should start adding this clarification, because we would have to add that to everything that comes out of the box with OS. What do you think?
There was a problem hiding this comment.
Since this is part of core OS functionality, we don't need to specify any prerequisites here.
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
There was a problem hiding this comment.
Thank you, @AntonEliatra! Please see my comments and let me know if you have any questions.
kolchfa-aws
added
4 - Doc review
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
|
@kolchfa-aws thats done now |
kolchfa-aws
added
5 - Editorial review
Signed-off-by: Nathan Bower <nbower@amazon.com>
* adding wrapper dsl query docs Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> * adding changes to the docs Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> * addressing the PR comments Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> * Apply suggestions from code review Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> * Update _query-dsl/specialized/wrapper.md Signed-off-by: Nathan Bower <nbower@amazon.com> --------- Signed-off-by: Anton Rubin <anton.rubin@eliatra.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com> Signed-off-by: Nathan Bower <nbower@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 5f2acf3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
adding wrapper dsl query docs
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.